This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
feat: improve event parameters #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
requested review from
bebraw,
ooflorent,
alexander-akait and
joshwiens
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 96.65% 96.64% -0.02%
==========================================
Files 7 7
Lines 269 268 -1
==========================================
- Hits 260 259 -1
Misses 9 9
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This PR improves and refactors the parameters for emitted events. All event parameters are now a single
objectwith named properties.This also fixes #132 and adds
optionsto thelisteningevent.Breaking Changes
Event parameter signatures have changed.
Additional Info